split: preserve non-UTF-8 bytes in output filename generation#11397
Merged
sylvestre merged 2 commits intouutils:mainfrom Apr 3, 2026
Merged
Conversation
Merging this PR will improve performance by 7.35%
Performance Changes
Comparing 
Footnotes
|
sylvestre
added a commit
to sylvestre/coreutils-1
that referenced
this pull request
Apr 3, 2026
* tests/split/non-utf8.sh: New test to ensure that non-UTF-8 bytes in the prefix and --additional-suffix are preserved as-is in output filenames, rather than being replaced by UTF-8 replacement characters. * tests/local.mk: Register new test. uutils/coreutils#11397
sylvestre
added a commit
to sylvestre/coreutils-1
that referenced
this pull request
Apr 3, 2026
* tests/split/non-utf8.sh: New test to ensure that non-UTF-8 bytes in the prefix and --additional-suffix are preserved as-is in output filenames, rather than being replaced by UTF-8 replacement characters. * tests/local.mk: Register new test. uutils/coreutils#11397
hubot
pushed a commit
to coreutils/coreutils
that referenced
this pull request
Apr 6, 2026
* tests/split/non-utf8.sh: New test to ensure that non-UTF-8 bytes in the prefix and --additional-suffix are preserved as-is in output filenames, rather than being replaced by UTF-8 replacement characters. * tests/local.mk: Register new test. uutils/coreutils#11397 #239
kevinburkesegment
pushed a commit
to kevinburkesegment/coreutils
that referenced
this pull request
Apr 6, 2026
…#11397) Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uutils split accepts non-UTF-8 prefix and suffix inputs but converts them with
to_string_lossy()when building chunk filenames. GNU keeps pathname bytes intact, while uutils rewrites invalid bytes to UTF-8 replacement characters.Reproduction Steps
Impact
Chunk files are created under rewritten names instead of the requested byte paths. This breaks GNU compatibility in non-UTF-8 environments and can cause filename collisions or misdirected output files.